-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: respect time range when building parquet reader #3947
Merged
killme2008
merged 5 commits into
GreptimeTeam:main
from
v0y4g3r:feat/respect-time-range
May 21, 2024
Merged
feat: respect time range when building parquet reader #3947
killme2008
merged 5 commits into
GreptimeTeam:main
from
v0y4g3r:feat/respect-time-range
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3947 +/- ##
==========================================
- Coverage 85.50% 85.17% -0.33%
==========================================
Files 977 977
Lines 169344 169412 +68
==========================================
- Hits 144793 144298 -495
- Misses 24551 25114 +563 |
evenyag
reviewed
May 21, 2024
waynexia
approved these changes
May 21, 2024
v0y4g3r
force-pushed
the
feat/respect-time-range
branch
from
May 21, 2024 12:28
0faa6af
to
6defa14
Compare
evenyag
approved these changes
May 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR converts the desired time range into
SimpleFilterContext
while building parquet readers so that the reader can filter out those rows outside the desired time range.Checklist