Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(naming): use the better naming for pubsub #3960

Merged

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented May 16, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Refactor the naming of pubsub and use names that are more in line with conventions, for example:

  • publish / subscribe / unsubscribe
  • subscription

...

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 83.05085% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 85.13%. Comparing base (9f4a6c6) to head (cf2679a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3960      +/-   ##
==========================================
- Coverage   85.64%   85.13%   -0.52%     
==========================================
  Files         973      978       +5     
  Lines      167045   168268    +1223     
==========================================
+ Hits       143073   143248     +175     
- Misses      23972    25020    +1048     

Copy link
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue May 17, 2024
Merged via the queue into GreptimeTeam:main with commit ca409a7 May 17, 2024
22 checks passed
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request May 21, 2024
@zyy17 zyy17 deleted the refactor/better-naming-for-pubsub branch June 3, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants