fix: prevent registering logical regions with AliveKeeper #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
requested review from
waynexia,
v0y4g3r,
evenyag and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3965 +/- ##
==========================================
- Coverage 85.65% 85.41% -0.25%
==========================================
Files 973 978 +5
Lines 167411 168325 +914
==========================================
+ Hits 143389 143767 +378
- Misses 24022 24558 +536 |
WenyXu
changed the title
AliveKeeper
WenyXu
changed the title
waynexia
reviewed
May 17, 2024
waynexia
approved these changes
May 17, 2024
WenyXu
added a commit
to WenyXu/greptimedb
that referenced
this pull request
May 21, 2024
…am#3965) * fix: register logical region * chore: fix Clippy * chore: apply suggestions from CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
fix #3596
What's changed and what's your intention?
Prevent registering logical regions with AliveKeeper.
Checklist