Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin cargo-ndk to 3.5.4 #3979

Merged
merged 1 commit into from
May 18, 2024
Merged

chore: pin cargo-ndk to 3.5.4 #3979

merged 1 commit into from
May 18, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 17, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

pin cargo-ndk version to 3.5.4 (Key Tech🥲)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 17, 2024
@WenyXu WenyXu marked this pull request as ready for review May 18, 2024 04:48
@WenyXu WenyXu requested a review from a team as a code owner May 18, 2024 04:48
@WenyXu WenyXu requested review from v0y4g3r and zyy17 May 18, 2024 04:48
zyy17
zyy17 approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You already touch the key :)

@tisonkun tisonkun added this pull request to the merge queue May 18, 2024
Merged via the queue into main with commit c71298d May 18, 2024
23 checks passed
@tisonkun tisonkun deleted the android-ci branch May 18, 2024 09:00
WenyXu added a commit to WenyXu/greptimedb that referenced this pull request May 21, 2024
@WenyXu
chore: pin cargo-ndk to 3.5.4 (GreptimeTeam#3979)
cdf4f49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@zyy17 zyy17 zyy17 approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @zyy17 @tisonkun