Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add 'contents: write' permission #3989

Merged
merged 1 commit into from
May 20, 2024

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented May 20, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

add contents: write permission for github action release workflow.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@zyy17 zyy17 requested a review from a team as a code owner May 20, 2024 03:56
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 20, 2024
@zyy17 zyy17 requested review from evenyag and tisonkun and removed request for a team May 20, 2024 03:57
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (df13832) to head (4c2c28c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3989      +/-   ##
==========================================
- Coverage   85.43%   85.15%   -0.28%     
==========================================
  Files         978      977       -1     
  Lines      169286   169275      -11     
==========================================
- Hits       144622   144149     -473     
- Misses      24664    25126     +462     

@evenyag evenyag added this pull request to the merge queue May 20, 2024
@zyy17 zyy17 removed this pull request from the merge queue due to a manual request May 20, 2024
@zyy17 zyy17 added this pull request to the merge queue May 20, 2024
Merged via the queue into GreptimeTeam:main with commit c50ff23 May 20, 2024
22 checks passed
@zyy17 zyy17 deleted the ci/add-contents-write branch May 20, 2024 06:38
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants