-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update centos yum source and specify cargo-binstall version #4248
Conversation
WalkthroughThis update focuses on addressing the end-of-life (EOL) of CentOS 7 by switching package repositories from Changes
Assessment against linked issues
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- docker/ci/centos/Dockerfile (1 hunks)
- docker/dev-builder/centos/Dockerfile (2 hunks)
- docker/dev-builder/ubuntu/Dockerfile (1 hunks)
- docker/dev-builder/ubuntu/Dockerfile-18.10 (1 hunks)
Files skipped from review due to trivial changes (1)
- docker/ci/centos/Dockerfile
Additional comments not posted (4)
docker/dev-builder/centos/Dockerfile (2)
5-7
: LGTM! Update to vault.centos.org is necessary and correctly implemented.The update to use
vault.centos.org
instead ofmirror.centos.org
is necessary due to CentOS 7 reaching its end-of-life. The sed commands correctly update the URLs in the yum repo files.
33-35
: LGTM! Specifying cargo-binstall version ensures compatibility.Installing
cargo-binstall
with a specific version (1.6.6) avoids errors related to unstable library features and ensures compatibility with the current Rust toolchain.docker/dev-builder/ubuntu/Dockerfile-18.10 (1)
46-48
: LGTM! Specifying cargo-binstall version ensures compatibility.Installing
cargo-binstall
with a specific version (1.6.6) avoids errors related to unstable library features and ensures compatibility with the current Rust toolchain.docker/dev-builder/ubuntu/Dockerfile (1)
58-60
: LGTM! Specifying cargo-binstall version ensures compatibility.Installing
cargo-binstall
with a specific version (1.6.6) avoids errors related to unstable library features and ensures compatibility with the current Rust toolchain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Resolve #4242
vault.centos.org
as default yum forcentos:7
image since CentOS 7 has reached EOL since 2024-07-01 thusmirror.centos.org
is no longer available;cargo-binstall
to adapt current rust toolchain;Checklist
Summary by CodeRabbit
vault.centos.org
due to EOL of CentOS 7.cargo-binstall
with version 1.6.6 to ensure compatibility with the current Rust toolchain and prevent errors related to unstable library features.