-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: lz4 compression #4329
revert: lz4 compression #4329
Conversation
This reverts commit 180dda1.
WalkthroughThis update primarily focuses on enhancing the compression methodology used in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/common/wal/src/config.rs (2 hunks)
- src/common/wal/src/config/kafka/datanode.rs (1 hunks)
- src/common/wal/src/config/kafka/standalone.rs (1 hunks)
Additional comments not posted (4)
src/common/wal/src/config/kafka/datanode.rs (1)
49-49
: Verify the impact of changing the default compression setting.The default compression for
DatanodeKafkaConfig
has been changed toCompression::Lz4
. Ensure that this change does not negatively impact performance or compatibility with existing data.src/common/wal/src/config/kafka/standalone.rs (1)
70-70
: Verify the impact of changing the default compression setting.The default compression for
StandaloneKafkaConfig
has been changed toCompression::Lz4
. Ensure that this change does not negatively impact performance or compatibility with existing data.src/common/wal/src/config.rs (2)
210-210
: Update test cases to reflect the new default compression setting.The test case for
DatanodeWalConfig
has been updated to reflect the new default compression setting ofCompression::Lz4
. Ensure that all relevant test cases are updated accordingly.
232-232
: Update test cases to reflect the new default compression setting.The test case for
StandaloneWalConfig
has been updated to reflect the new default compression setting ofCompression::Lz4
. Ensure that all relevant test cases are updated accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4329 +/- ##
==========================================
- Coverage 85.16% 84.92% -0.25%
==========================================
Files 1060 1060
Lines 188656 189048 +392
==========================================
- Hits 160671 160544 -127
- Misses 27985 28504 +519 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the document?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- src/common/wal/src/config.rs (4 hunks)
- src/common/wal/src/config/kafka/datanode.rs (3 hunks)
- src/common/wal/src/config/kafka/standalone.rs (3 hunks)
- src/log-store/src/kafka/client_manager.rs (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- src/common/wal/src/config.rs
- src/common/wal/src/config/kafka/datanode.rs
- src/common/wal/src/config/kafka/standalone.rs
Additional comments not posted (1)
src/log-store/src/kafka/client_manager.rs (1)
101-101
: Reverted change: Set compression to LZ4.The
compression
field is set toCompression::Lz4
. Ensure that this aligns with the PR's objective to revert the previous commit. Verify that the default compression method is correctly handled throughout the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
revert: lz4 compression
This reverts commit 180dda1.
Checklist
Summary by CodeRabbit
NoCompression
toLz4
for faster data transmission and reduced storage size.