feat(mito): parquet memtable reader #4967

v0y4g3r · 2024-11-10T07:12:20Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR adds basic support for reading parquet files residing in memory, by reusing some structs and functions in sst mod.

Since the lack of keyword generics, we have to refactor the parquet reader by extracting the methods and functions that are not related to async/sync IO operations to a [___]Base structs that can be shared between memory and files.

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.

coderabbitai · 2024-11-10T07:12:26Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-11-11T00:02:58Z

Codecov Report

Attention: Patch coverage is 85.20115% with 103 lines in your changes missing coverage. Please review.

Project coverage is 83.82%. Comparing base (42bf7e9) to head (356bb47).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4967      +/-   ##
==========================================
- Coverage   84.03%   83.82%   -0.21%     
==========================================
  Files        1146     1149       +3     
  Lines      213828   214347     +519     
==========================================
- Hits       179690   179683       -7     
- Misses      34138    34664     +526

src/mito2/src/memtable/bulk/part.rs

src/mito2/src/sst/parquet/reader.rs

src/mito2/src/memtable/bulk/row_group_reader.rs

- Added early return when fetch_ranges is empty to optimize performance. - Replaced inline chunk data assignment with a call to `assign_dense_chunk` for cleaner code.

- Introduced `RangeBase` to `BulkIterContext` for improved filter handling. - Implemented filter application in `BulkPartIter` to prune batches based on predicates. - Updated `SimpleFilterContext::new_opt` to be public for broader access.

- Modified `BulkPart::read` to return `Option<BoxedBatchIterator>` to handle cases where no row groups are selected. - Added logic to return `None` when all row groups are filtered out. - Updated tests to handle the new return type and added a test case to verify behavior when no row groups match the pr

…et metadata and integrate it into BulkPartEncoder

Change BulkPartEncoder row_group_size from Option to usize and update tests

…le iteration and refactor part reading • Introduce context module to encapsulate context for bulk memtable iteration. • Refactor BulkPart to use BulkIterContextRef for reading operations. • Remove redundant code in BulkPart by centralizing context creation and row group pruning logic in the new context module. • Create new file context.rs with structures and logic for handling iteration context. • Adjust part_reader.rs and row_group_reader.rs to reference the new BulkIterContextRef.

… implementations in memtable and parquet reader modules • Rename RowGroupReaderVirtual to RowGroupReaderContext for clarity. • Replace BulkPartVirt with direct usage of BulkIterContextRef in MemtableRowGroupReader. • Simplify MemtableRowGroupReaderBuilder by directly passing context instead of creating a BulkPartVirt instance. • Update RowGroupReaderBase to use context field instead of virt, reflecting the trait renaming and usage. • Modify FileRangeVirt to FileRangeContextRef and adjust implementations accordingly.

…on and remove unused code • Centralize creation of SerializedPageReader in RowGroupBase::column_reader method. • Remove unused RowGroupCachedReader and related code from MemtableRowGroupPageFetcher. • Eliminate redundant error handling for invalid column index in multiple places.

evenyag

Others LGTM

evenyag · 2024-11-19T06:58:05Z

src/mito2/src/memtable/bulk/part.rs

+/// Loads metadata.
+fn load_metadata(buf: &Bytes) -> Result<Arc<ParquetMetaData>> {
+    let options = ArrowReaderOptions::new()
+        .with_page_index(true)
+        .with_skip_arrow_metadata(true);
+    let metadata = ArrowReaderMetadata::load(buf, options).context(error::ReadDataPartSnafu)?;
+    Ok(metadata.metadata().clone())
+}


Maybe we can remove this function.

evenyag · 2024-11-19T07:03:21Z

src/mito2/src/sst/parquet/stats.rs

@@ -27,7 +27,7 @@ use store_api::storage::ColumnId;
 use crate::sst::parquet::format::ReadFormat;

 /// Statistics for pruning row groups.
-pub(crate) struct RowGroupPruningStats<'a, T> {
+pub struct RowGroupPruningStats<'a, T> {


Do we need to pub this? Maybe pub(crate) is enough?

evenyag · 2024-11-19T07:04:11Z

src/mito2/src/sst/parquet/row_group.rs

+            .collect::<Vec<_>>()
+    }
+
+    pub(crate) fn assign_dense_chunk(


nitpick: Maybe add some documents to the input and return value of some methods in RowGroupBase.

github-actions bot added the docs-not-required This change does not impact docs. label Nov 10, 2024

v0y4g3r marked this pull request as ready for review November 10, 2024 23:44

v0y4g3r requested review from evenyag and waynexia as code owners November 10, 2024 23:44

evenyag reviewed Nov 14, 2024

View reviewed changes

v0y4g3r added 17 commits November 14, 2024 16:24

wip: row group reader base

d98d10b

wip: memtable row group reader

5c5e36c

Refactor MemtableRowGroupReader to streamline data fetching

068dc06

- Added early return when fetch_ranges is empty to optimize performance. - Replaced inline chunk data assignment with a call to `assign_dense_chunk` for cleaner code.

wip: row group reader

b5a5ff2

wip: reuse RowGroupReader

34478d0

wip: bulk part reader

4470d7c

Enhance BulkPart Iteration with Filtering

69008a5

- Introduced `RangeBase` to `BulkIterContext` for improved filter handling. - Implemented filter application in `BulkPartIter` to prune batches based on predicates. - Updated `SimpleFilterContext::new_opt` to be public for broader access.

chore: add prune test

6d7c8d6

fix: clippy

cc422ab

fix: introduce prune reader for memtable and add more prune test

1719213

refactor/separate-paraquet-reader: Add helper function to parse parqu…

c9ceb72

…et metadata and integrate it into BulkPartEncoder

refactor/separate-paraquet-reader:

dbb4e3e

Change BulkPartEncoder row_group_size from Option to usize and update tests

chore: rebase main and resolve conflicts

356bb47

v0y4g3r force-pushed the refactor/separate-paraquet-reader branch from 0d0d634 to 356bb47 Compare November 15, 2024 00:34

v0y4g3r requested a review from evenyag November 15, 2024 00:35

evenyag approved these changes Nov 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mito): parquet memtable reader #4967

feat(mito): parquet memtable reader #4967

v0y4g3r commented Nov 10, 2024 •

edited

Loading

coderabbitai bot commented Nov 10, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Nov 11, 2024 •

edited

Loading

evenyag left a comment

evenyag Nov 19, 2024

evenyag Nov 19, 2024

evenyag Nov 19, 2024

feat(mito): parquet memtable reader #4967

Are you sure you want to change the base?

feat(mito): parquet memtable reader #4967

Conversation

v0y4g3r commented Nov 10, 2024 • edited Loading

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Checklist

coderabbitai bot commented Nov 10, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Nov 11, 2024 • edited Loading

Codecov Report

evenyag left a comment

Choose a reason for hiding this comment

evenyag Nov 19, 2024

Choose a reason for hiding this comment

evenyag Nov 19, 2024

Choose a reason for hiding this comment

evenyag Nov 19, 2024

Choose a reason for hiding this comment

v0y4g3r commented Nov 10, 2024 •

edited

Loading

coderabbitai bot commented Nov 10, 2024 •

edited

Loading

codecov bot commented Nov 11, 2024 •

edited

Loading