-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ethereumjs and cryptography libraries #427
Comments
GridPlus is one of packages that is used by metamask. It would be great to update gridplus when metamask would get new cryptography. Should I make a pull request? @alex-miller-0 @douglance @ledbetterljoshua All of those can be replaced by
|
@paulmillr thanks for following up - a PR would be appreciated! One issue to watch out for would be Overall I would prefer to have a single crypto library so I support this. Even better if MetaMask is already importing it. |
if you want to keep buffers around, I can do Buffer.from(ui8a) in all calls, that wrapper shouldn't be a noticeable perf hit. They are basically the same. We've chosen to get rid of buffers in the eth-crypto because ui8a are native to browsers while Buffers require a third party dependency. |
We want to get rid of buffers too. I was just pointing out that we still use them and don't want to mix types. I think the best path forward would be converting everything to u8a but that will require some work. |
js-sha3
andsecp256k1
should be replaced byethereum-cryptography
package: https://github.com/ethereum/js-ethereum-cryptography. Check out the blog post about it: https://medium.com/nomic-labs-blog/a-safer-smaller-and-faster-ethereum-cryptography-stack-5eeb47f62d79Also ethereumjs team did a great job on the new releases, which should be out any way now. The releases switch from bn.js to native bigints and massively decrease dependency burden.
The text was updated successfully, but these errors were encountered: