-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature[next]: ITIR transformation & gtfn codegen caching #1474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: We just observed that even in case the compilation fails the cache is populated, which is not so great. |
1 task
SF-N
added a commit
that referenced
this pull request
Nov 7, 2024
…1690) Add memory and disk-based caching to other workflow steps and, therefore, removing unnecessary overhead of Program calls and significantly improving time to first computed value. Changes: - setting `cached = True` for `func_to_past_factory` - wrapping the GTFN code generation into a `CachedStep` (using `Diskcache`) which is activated when setting `otf_workflow__cached_translation=True`, similar as in [PR#1474](#1474) (without CachedStep) - Fixing hash function of `ProgramDefinition` - New tests for added functionality This leads to a runtime decrease of about 25% for PMAP-G in the advect-uniform testcase (5 hours) after caches are populated. TODOs: - [x] improving hash functions of `fingerprint_stage` --------- Co-authored-by: Till Ehrengruber <[email protected]> Co-authored-by: Enrique G. Paredes <[email protected]>
Absorbed in #1690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly improves time to first computed value by caching the ITIR transformations and GTFN code generation.
This is not meant to be merged. Just an intermediate solution to make debugging more practical. In PMAP-G this improves the time for the first time-step for a larger test-case from ~10 minutes to ~40s.