feat[next]: Gtir concat where #1713
Draft
+1,693
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tehrengruber
force-pushed
the
GTIR_concat_where
branch
from
71026ff to
05e74c2
Compare
tehrengruber
changed the title
…pressions connected by logical operators (they are resolved by NestConcatWheres): running fine in roundtrip_default, gtfn_run_gtfn and gtfn_run_gtfn_imperative
…PMAP-LES, DerefCond is still a draft, but works for the tested cases
| ): # TODO: add tests | ||
| arg1, arg2 = node.args | ||
| if isinstance(arg2, ir.AxisLiteral): | ||
| # take complementary operation if we have e.g. `IDim > 1` use `1 <= IDim` |
There was a problem hiding this comment.
TODO: the comment is wrong
…type' into store_lambda_param_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description will follow.
TODO: remove #1863 again
Depends on: #1874