Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[next][dace]: lowering of scan to SDFG #1776

Open
wants to merge 216 commits into
base: main
Choose a base branch
from
Open

feat[next][dace]: lowering of scan to SDFG #1776

wants to merge 216 commits into from
+793 −53

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Dec 6, 2024 •
edited
Loading

This PR contains the lowering of the scan builtin function.

DropD and others added 30 commits November 18, 2024 13:38
@DropD
[wip] start adding sdfg convertible Program for dace-fieldview
4c41f02
@DropD
add SDFGConvertible Program replacement to dace_fieldview
481af34
@DropD
improve generate_sdfg args, remove old Program replacement
ad0a7b2
@DropD
Merge branch 'main' into gtir-sdfg-convertible
307b537
@DropD
turn auto_optimize back on in __sdfg__
7c4d197
@DropD
disable auto_opt once again in __sdfg__
3c56151
@DropD
support only CUDA device type in dace_fieldview Program
c5b4c43
@DropD
[wip] bring back extra sdfg attributes for halo placement
835c115
@DropD
partially add halo exchange helper attrs with tests
c126cb2
@DropD
add dace/gt4py type parsing crosscheck
0b90583
@DropD
Merge branch 'main' into gtir-sdfg-convertible
8c1f9f4
@DropD
fix dace_fieldview.program tests
77c250b
@DropD
refactor extractors and remove debuginfo warning
f8ec8f5
@DropD
Merge branch 'main' into gtir-sdfg-convertible
5831591
@edopao
scan - working draft
df1847a
@edopao
Merge remote-tracking branch 'origin/main' into dace-gtir-scan
89ca8f7
@edopao
Merge remote-tracking branch 'origin/main' into dace-gtir-scan
f22eb64
@edopao
Improve utility functions for tuples
c26d906
@edopao
Fix for empty field domain
ba0a9ba
@edopao
Merge remote-tracking branch 'origin/main' into dace-gtir-scan
ac7acf8
@edopao
Merge remote-tracking branch 'origin/main' into dace-gtir-scan
877d81e
@edopao
Merge remote-tracking branch 'origin/main' into dace-gtir-scan
8baf6d1
@edopao
Add exclusive if_ in dataflow
784b573
@edopao
Better handling of isolated nodes
de9c9de
@edopao
Fix field offset in nested SDFG context
14e66e8
@edopao
fix problem with dereferencil of 1D vertical fields inside scan
fcfaf72
@edopao
generalize previous fix to all scan input fields
79204ee
@edopao
minor edit
5fe461a
@edopao
fix out-of-bound access
a4bde3a
@edopao
Better handling of isolated nodes
c75a8e4
edopao added 15 commits January 15, 2025 11:07
@edopao
Merge remote-tracking branch 'origin/dace-gtir-iterator_view' into da…
de83a3b 
…ce-gtir
@edopao
address review comment
cd48985
@edopao
fix doc test
4437108
@edopao
Merge remote-tracking branch 'origin/dace-gtir-iterator_view' into da…
70ba0c8 
…ce-gtir
@edopao
Merge remote-tracking branch 'origin/dace-gtir-remove_unused_connecti…
fd266cb 
…vity_arrays' into dace-gtir
@edopao
address review comment (1)
d7671a7
@edopao
Merge remote-tracking branch 'origin/dace-gtir-iterator_view' into da…
85ff971 
…ce-gtir
@edopao
Merge remote-tracking branch 'origin/dace-gtir' into dace-gtir-scan
849a75a
@edopao
Merge remote-tracking branch 'origin/main' into dace-gtir-scan
1e6a873
@edopao
fix rebase conflicts
733816a
@edopao
Merge remote-tracking branch 'origin/main' into dace-gtir-scan
a734b71
@edopao
fix pre-commit
06e9420
@edopao
fix test marker
4e57834
@edopao
Merge remote-tracking branch 'origin/main' into dace-gtir-scan
b875eca
@edopao
address review comment
13d7ca1
philip-paul-mueller
philip-paul-mueller reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks generally good but I would strongly suggest to split the translate_scan function into several smaller functions that each handle one particular aspect of the translation.

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_sdfg.py Outdated Show resolved Hide resolved
edopao
edopao commented Jan 17, 2025
View reviewed changes
Copy link
Contributor Author

@edopao edopao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed all comments except splitting the lowering of the scan into multiple functions / separate module. I will push another commit on this PR for that, so it is easier to review.

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated

# parse the dataflow input and output symbols
lambda_flat_args: dict[str, FieldopData] = {}
lambda_field_offsets: dict[str, Optional[list[dace.symbolic.SymExpr]]] = {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Be aware that there will be another PR that will change the way we setup field offsets, to support new features in recent GTIR PRs (#1779).

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_sdfg.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
@edopao
Copy link
Contributor Author

edopao commented Jan 17, 2025

Thanks for the review comments. I have moved the scan translator to a separate module and split it into small functions. At some point I stopped, in order to avoid too much fragmentation. I agree, it looks much better now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-paul-mueller philip-paul-mueller Awaiting requested review from philip-paul-mueller

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edopao @philip-paul-mueller @DropD