bug[next]: Fix accept args #1830
Open
+505
−463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehrengruber
commented
Jan 30, 2025
| and a_arg != b_arg | ||
| and not is_concretizable(a_arg, to_type=b_arg) | ||
| ): | ||
| if b_arg is not UNDEFINED_ARG and a_arg != b_arg and not is_compatible_type(a_arg, b_arg): |
There was a problem hiding this comment.
This and the change below is only real change in this PR.
havogt
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type_info.accept_argsis used in the iterator type inference to check if a node with typets.FunctionTypeis callable for a given set of arguments here. This failed when the function type had an iterator argument withposition_dims="unknown". This PR promotes the_is_compatible_typefunction from the iterator type inference to a shared function available in all type systems and switchesaccept_args(or more preciselyfunction_signature_incompatibilities_func) to use that function instead ofis_concretizable.Additionally this PR contains a small cleanup of the type deduction / type system tests:
test_type_deduction.pywas moved from integration to unit tests (as it only contains unit tests).test_type_deduction.pyas they are not specific to the frontend type deduction.