Skip to content

GemStone update #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Sep 29, 2025
Merged

GemStone update #3

merged 33 commits into from
Sep 29, 2025

Conversation

@tukanos
Copy link

@tukanos tukanos commented Sep 29, 2025

No description provided.

vonbecmann and others added 30 commits March 9, 2021 23:30
@vonbecmann
add Pharo32-8.0 to travis.yml
e065703 
add Pharo32-8.0
@astares
Merge pull request GsDevKit#1 from vonbecmann/patch-1
ac17820 
add Pharo32-8.0 to travis.yml
@astares
Update README.md
db5888a
@astares
Update README.md
59afe62
@astares
Add CI group
d65d24f
@astares
Add Github action and smalltalk CI
b614aac
@astares
Add 6.1 to README
17cf653
@astares
Cleanup: Remove ConfigurationOfBitmapCharacterSet
3fa2dae 
Fix GsDevKit#2
@astares
Merge pull request GsDevKit#3 from astares/issue_2
428f22f 
Cleanup: Remove ConfigurationOfBitmapCharacterSet
@astares
Cleanups like formatting and lint checking
71e121c
@astares
Merge pull request GsDevKit#4 from astares/cleanups
9adc978 
Cleanups like formatting and lint checking
@astares
Fix labels, only P7 to P11
db08a6d
@astares
Update README.md
3fb4dc2
@astares
Remove BitmapCharacterSet class>>#inspectorClass
c60d3d0 
Fix pharo-contributions#5
@astares
Merge pull request pharo-contributions#6 from astares/issue_5
5dadea9 
Remove BitmapCharacterSet class>>#inspectorClass
@astares
Update .unit-tests.ston
22b8c9d
@astares
Use codecov-action@v1 to check if that makes a difference
b6fd4ad
@astares
check if the - makes a difference in displaying coverage
9209847
@astares
Update README.md
8d7b3f8
@astares
Update build.yml
a0f4515
@astares
BitmapCharacterSetTest>>#assertSet:copiedFrom:equals: should use isNo…
e4bc5e2 
…tNil

Fix pharo-contributions#8
@astares
Merge pull request pharo-contributions#9 from pharo-contributions/8-B…
4f7353b 
…itmapCharacterSetTestassertSetcopiedFromequals-should-use-isNotNil

BitmapCharacterSetTest>>#assertSet:copiedFrom:equals: should use isNotNil
@astares
Update build.yml with P13
0a06112
@astares
Update README.md
31b3412
@astares
Formatting
62ee106
Merge remote-tracking branch 'upstream/master' into gemstone
e47c961
Adding CI group
56d564e
Merge pull request GsDevKit#3 from astares/issue_2
7d414b6 
Cleanup: Remove ConfigurationOfBitmapCharacterSet
Partially done - Merge pull request GsDevKit#4 from astares/cleanups
49515cd 
Cleanups like formatting and lint checking
Merge pull request pharo-contributions#6 from astares/issue_5
f856c94 
Remove BitmapCharacterSet class>>#inspectorClass
Merge pull request pharo-contributions#9 from pharo-contributions/8-B…
728ab18 
…itmapCharacterSetTestassertSetcopiedFromequals-should-use-isNotNil

BitmapCharacterSetTest>>#assertSet:copiedFrom:equals: should use isNotNil

For GemStone:
- changed the category to match the Pharo one
- renamed -Core to -Base package to match the upstream
- ignoring manifest changes
- ignoring symbols->string changes as this was already done
@tukanos
Copy link
Author

tukanos commented Sep 29, 2025 •
edited
Loading

@dalehenrich I have update the CI according to your request(s). Your original comments are in closed PR as I have tried some workflows. This caused the original PR to be closed. Here is the original comment link

@tukanos
Copy link
Author

tukanos commented Sep 29, 2025 •
edited
Loading

There were three failing tests:

 ✗ #testConcatenation (146ms)
 ✗ #testCopy (1ms)
 ✗ #testCopyEmpty (1ms)

Now everything passes (only Post Workflow Status To Slack fails) as I have created GemStone compatible code.

If PharoCompatibility (GsPharo) is loaded the tests started to pass without any modification. You probably do not want to introduce new dependency on PharoCompatibility.

How do you deal with such situation? I want to know for future reference in more complex situations.

@tukanos tukanos changed the title Gem stone update GemStone update Sep 29, 2025
@tukanos
Copy link
Author

tukanos commented Sep 29, 2025 •
edited
Loading

I have noticed the bitmapcharacterset.gs file. I have not updated that one. Why is there?

@dalehenrich
Copy link
Member

dalehenrich commented Sep 29, 2025

I have noticed the bitmapcharacterset.gs file. I have not updated that one. Why is there?

I added as an example of using a .solo script to read Rowan Project definitions and write the project as a .gs file ... so it doesn't need to be updated

@dalehenrich dalehenrich merged commit 0422dd4 into GsDevKit:gemstone Sep 29, 2025
9 of 10 checks passed
@dalehenrich
Copy link
Member

dalehenrich commented Sep 29, 2025

How do you deal with such situation? I want to know for future reference in more complex situations.

I think that first order you do as you did and change the code to be compatible with GemStone ... if the changes are too widespread, then adding a gemstone-specific dependency to another baseline is the best answer ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tukanos @dalehenrich @vonbecmann @astares