Keep GsDevKit/Grease up to date with Seaside/Grease #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es that otherwise result
Address Pharo12 deprecations
…compatibility with versions of Seaside older than 3.5.6.
Fix slime dependency
…Seaside development
This reverts commit f01435f.
Slime portability split
Implement for Pharo and add Deprecation.
- move methods from GRPharoPlatform to GRSqeuakPlatform - keep GRPharoPlatform as empty - migrate from FileSystem to FileDirectory - implement missing methods - custom implementation of #openDebuggerOn: - add test for deprecationExceptionSet
Improve Squeak 6 Support
Support Pharo native Deprecation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 85.15% 85.58% +0.43%
==========================================
Files 2051 2050 -1
Lines 14115 14100 -15
==========================================
+ Hits 12019 12067 +48
+ Misses 2096 2033 -63 ☔ View full report in Codecov by Sentry. |
|
Looks like tests have passed but the CI action is failing because the config references a secret that is not accessible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We treat the SeasideSt/Grease repo as the master for code.
Nothing much changed for GemStone in this one but this just tidies things up. I already cherry-picked @kurtkilpela's commit 1c70803 to SeasideSt/Grease in SeasideSt@1c70803 to make sure we have that change in the master repo.