-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Qt6.2 #23
Upgrade to Qt6.2 #23
Conversation
1120bfe
to
4af5dbf
Compare
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 77.63% 77.64% +0.01%
==========================================
Files 35 35
Lines 2423 2425 +2
==========================================
+ Hits 1881 1883 +2
Misses 542 542
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Could be related to pyqtgraph? |
Yes, indeed. It turns out that pyqtgraph failed to determine that it should use PyQt6 and was silently still using PyQt5 in the background. Forcing PyQt6 in 90164c8 solved this problem. |
This should be good to be reviewed now. As far as I can tell, everything still works as it should. |
@@ -1,3 +1,7 @@ | |||
import os | |||
|
|||
os.environ["PYQTGRAPH_QT_LIB"] = "PyQt6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only important if PyQt5 is installed, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to say yes. But pyqtgraph was very thorough in finding pyqt5 and found it even though it was not installed in the ENV running Impose, but in the global python environment. And since in the env only pyqt6 was available running Impose failed then.
I would like to leave this in, just to be sure pyqtraph uses pyqt6, because otherwise it will fail completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort. Could you please update the changelog here as well (bump xyz from a to b
)?
3721a95
to
a7bbb9a
Compare
Done. |
This PR upgrades PyQt5 to PyQt6 in order to support Macs with M1 Arm processor, which are supported natively from Qt6.2 on.