Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening bmlab files with multiple repetitions #26

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

raimund-schluessler
Copy link
Contributor

Because I am obviously stupid 🙈🙃, the implementation of #22 had an issue with opening bmlab files with multiple repetitions. This fixes it.
We should add a bmlab test file for checking this, but I don't have a small enough file at hand at the moment.
@juko1 This fixes BrillouinMicroscopy/BMicro#150.

@raimund-schluessler raimund-schluessler added the bug Something isn't working label Mar 23, 2022
@raimund-schluessler raimund-schluessler added this to the 0.2.2 milestone Mar 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #26 (5b46c31) into main (17102d8) will increase coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   77.64%   78.24%   +0.59%     
==========================================
  Files          35       35              
  Lines        2425     2482      +57     
==========================================
+ Hits         1883     1942      +59     
+ Misses        542      540       -2     
Impacted Files Coverage Δ
impose/formats/fmt_bm_bmlab.py 100.00% <100.00%> (+3.77%) ⬆️
impose/gui/visualize.py 93.37% <0.00%> (-0.15%) ⬇️
impose/flblend.py 99.39% <0.00%> (+1.07%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@paulmueller
Copy link
Member

I would be happy to merge this if you added the test file. Up to 1MB is still fine I think.

@raimund-schluessler
Copy link
Contributor Author

I would be happy to merge this if you added the test file. Up to 1MB is still fine I think.

Done. The test successfully fails without the fix in 360b371 🙂

Copy link
Member

@paulmueller paulmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking to the new test data naming scheme.

@paulmueller paulmueller merged commit 4ca2123 into main Mar 24, 2022
@raimund-schluessler raimund-schluessler deleted the fix/noid/multi-rep-bmlab branch March 24, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load evaluated repetition (via BMicro dmg) into impose
3 participants