Update java version and some refactoring #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added caching for getPermissionsAsMap since it's unmodifiable
This blocks the usage of the sync version of save on the main thread, avoiding accidental usage and lag spikes
This is not necessary as it's a copy on write array
Some casts were unecessary since this is bukkit only code
Implementation like LuckPerms block running this on main thread
Saves one hash table lookup
Used by storageContext to check for primary thread
Same hashCode and equals as bukkit uses internally
niekschoemaker
commented
Aug 5, 2024
niekschoemaker
commented
Aug 5, 2024
|
@niekschoemaker I really appreciate the effort. Can we perhaps discuss these changes through Discord? You can find me in the GufliMC server https://discord.com/invite/UFEcurxWsV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes have been tested, can't speak for every situation though.
Ie. the multithreading, LuckPerms requires it, but I'm not sure if other plugins support it.
Same goes for update to java 17, paper runs on java 21 as of version 1.20.6, and on 17 since at least 1.18.2, so updating to java 17 should be fine.
And update of ebean also required this.
Probably should go together with upping the version van 7 to 8 since this might break plugins depending on this as the class version gets upped quite a bit.