Skip to content

Commit

Permalink
Merge: merge 0.13.2.beta features
Browse files Browse the repository at this point in the history
  • Loading branch information
ciusji committed Mar 30, 2023
1 parent 18d0b98 commit 007b74c
Show file tree
Hide file tree
Showing 1,955 changed files with 24,727 additions and 78,367 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Individual scopes

# Review from UI owners for changes around UI code
/openmetadata-ui/src/main/resources/ui/ @harshach @shahsank3t
/openmetadata-ui/src/main/resources/ui/ @open-metadata/ui

# Review from Backend owners for changes around Backend code
/openmetadata-service/ @open-metadata/backend
Expand Down
7 changes: 0 additions & 7 deletions .github/ISSUE_TEMPLATE/config.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Feature request
about: Suggest an idea for this project
title: ''
labels: 'enhancement'
labels: ''
assignees: ''
---

Expand Down
70 changes: 23 additions & 47 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,58 +1,34 @@
<!--
Thank you for your contribution!
Unless your change is trivial, please create an issue to discuss the change before creating a PR.
-->

### Describe your changes:

Fixes <issue-number>

<!--
Short blurb explaining:
- What changes did you make?
- Why did you make them?
- How did you test your changes?
-->

I worked on ... because ...

<!-- For frontend related change, please add screenshots and/or videos of your changes preview! -->
### Describe your changes :
<!-- Explain what you have done & tag your assigned issue !-->
I worked on the ..... because ...

#
### Type of change:
### Type of change :
<!-- You should choose 1 option and delete options that aren't relevant -->
- [ ] Bug fix
- [ ] Improvement
- [ ] New feature
- [x] Bug fix
- [x] Improvement
- [x] New feature
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation

#
### Frontend Preview (Screenshots) :
<p align="center">For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
</p>

#
### Checklist:
<!-- add an x in [] if done, don't mark items that you didn't do !-->
- [x] I have read the [**CONTRIBUTING**](https://docs.open-metadata.org/developers/contribute) document.
- [ ] My PR title is `Fixes <issue-number>: <short explanation>`
- [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

<!-- Based on the type(s) of your change, uncomment the required checklist 👇 -->

<!-- Bug fix
- [ ] I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.
-->
- [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [x] All new and existing tests passed.

<!-- Improvement
- [ ] I have added tests around the new logic.
- [ ] For connector/ingestion changes: I updated the documentation.
-->

<!-- New feature
- [ ] The issue properly describes why the new feature is needed, what's the goal, and how we are building it. Any discussion
or decision-making process is reflected in the issue.
- [ ] I have updated the documentation.
- [ ] I have added tests around the new logic.
-->

<!-- Breaking change
- [ ] I have added the tag `Backward-Incompatible-Change`.
-->
#
### Reviewers
<!-- Please see the contributing guidelines and then add your reviewer(s) !-->
<!--- OpenMetadata community thanks you for explaining your changes in detail !-->
<!--- If you are unsure of people to review your work, you can add anyone of these developers :) !-->
<!--- Frontend: @open-metadata/ui -->
<!--- Backend: @open-metadata/backend -->
<!--- Ingestion: @open-metadata/ingestion -->
4 changes: 0 additions & 4 deletions .github/teams.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@
- '@Sachin-chaurasiya'
- '@shahsank3t'
- '@ShaileshParmar11'
- '@karanh37'
- '@harshach'
- '@mohityadav766'
- '@sureshms'
- '@akash-jain-10'
- '@Vj-L'
- '@dhruvinmaniar123'
- '@ShilpaVernekar'
- '@snyk-bot'
- '@dependabot'
Expand All @@ -44,7 +42,6 @@ UI:
- '@Sachin-chaurasiya'
- '@shahsank3t'
- '@ShaileshParmar11'
- '@karanh37'

backend:
- '@harshach'
Expand All @@ -54,7 +51,6 @@ backend:
devops:
- '@akash-jain-10'
- '@Vj-L'
- '@dhruvinmaniar123'

documentation:
- '@ShilpaVernekar'
9 changes: 2 additions & 7 deletions .github/workflows/airflow-apis-tests-3_9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,10 @@ jobs:
make install_all install_test
- name: Start Server and Ingest Sample Data
uses: nick-fields/[email protected]
env:
INGESTION_DEPENDENCY: "mysql,elasticsearch"
with:
timeout_minutes: 30
max_attempts: 2
retry_on: error
command: ./docker/run_local_docker.sh -m no-ui
run: ./docker/run_local_docker.sh
timeout-minutes: 30

- name: Run Python Tests & Record Coverage
run: |
Expand All @@ -122,7 +118,6 @@ jobs:
-Dsonar.pullrequest.github.repository=OpenMetadata
-Dsonar.scm.revision=${{ github.event.pull_request.head.sha }}
-Dsonar.pullrequest.provider=github
- name: Push Results to Sonar
uses: sonarsource/sonarcloud-github-action@master
if: ${{ github.event_name == 'push' }}
Expand Down
26 changes: 1 addition & 25 deletions .github/workflows/cypress-integration-tests-mysql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,31 +65,7 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Cache Maven Dependencies
id: cache-output
uses: actions/cache@v3
with:
path: ~/.m2
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
- name: Get yarn cache directory path
if: steps.cache-output.outputs.exit-code == 0
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@v3
if: steps.yarn-cache-dir-path.outputs.exit-code == 0
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: Set up JDK 11
if: steps.cache-output.outputs.exit-code == 0
uses: actions/setup-java@v3
with:
java-version: '11'
Expand Down Expand Up @@ -161,6 +137,6 @@ jobs:

- name: Clean Up
run: |
cd ./docker/development
cd ./docker/local-metadata
docker compose down --remove-orphans
sudo rm -rf ${PWD}/docker-volume
26 changes: 1 addition & 25 deletions .github/workflows/cypress-integration-tests-postgresql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,31 +65,7 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Cache Maven Dependencies
id: cache-output
uses: actions/cache@v3
with:
path: ~/.m2
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
- name: Get yarn cache directory path
if: steps.cache-output.outputs.exit-code == 0
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

- uses: actions/cache@v3
if: steps.yarn-cache-dir-path.outputs.exit-code == 0
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: Set up JDK 11
if: steps.cache-output.outputs.exit-code == 0
uses: actions/setup-java@v3
with:
java-version: '11'
Expand Down Expand Up @@ -161,6 +137,6 @@ jobs:

- name: Clean Up
run: |
cd ./docker/development
cd ./docker/local-metadata
docker compose down --remove-orphans
sudo rm -rf ${PWD}/docker-volume
2 changes: 1 addition & 1 deletion .github/workflows/docker-openmetadata-db.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ jobs:
platforms: linux/amd64,linux/arm64
push: ${{ github.event_name == 'release' || github.event_name == 'workflow_dispatch' }}
tags: ${{ steps.input_check.outputs.tags }}
file: ./docker/mysql/Dockerfile_mysql
file: ./docker/local-metadata/Dockerfile_mysql
2 changes: 1 addition & 1 deletion .github/workflows/docker-openmetadata-postgres.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ jobs:
platforms: linux/amd64,linux/arm64
push: ${{ github.event_name == 'release' || github.event_name == 'workflow_dispatch' }}
tags: ${{ steps.input_check.outputs.tags }}
file: ./docker/postgresql/Dockerfile_postgres
file: ./docker/local-metadata/Dockerfile_postgres
6 changes: 3 additions & 3 deletions .github/workflows/docker-openmetadata-server.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,9 @@ jobs:
if ${{ github.event_name == 'release' }}; then
echo "tags=openmetadata/server:${{ env.DOCKER_RELEASE_TAG }},openmetadata/server:latest" >> $GITHUB_OUTPUT
elif ${{ github.event_name == 'workflow_dispatch' && inputs.push_latest_tag_to_release }}; then
echo "tags=openmetadata/server:${{ env.DOCKER_RELEASE_TAG }},openmetadata/server:latest" >> $GITHUB_OUTPUT
echo "tags=openmetadata/server:${{inputs.tag}},openmetadata/server:latest" >> $GITHUB_OUTPUT
else
echo "tags=openmetadata/server:${{ env.DOCKER_RELEASE_TAG }}" >> $GITHUB_OUTPUT
echo "tags=openmetadata/server:${{ inputs.tag }}" >> $GITHUB_OUTPUT
fi
- name: Build and push if event is workflow_dispatch and input is checked
Expand All @@ -155,4 +155,4 @@ jobs:
platforms: linux/amd64,linux/arm64
push: ${{ github.event_name == 'release' || github.event_name == 'workflow_dispatch' }}
tags: ${{ steps.input_check.outputs.tags }}
file: ./docker/docker-compose-quickstart/Dockerfile
file: ./docker/metadata/Dockerfile
38 changes: 0 additions & 38 deletions .github/workflows/maven-build-skip.yml

This file was deleted.

25 changes: 3 additions & 22 deletions .github/workflows/maven-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,8 @@ on:
- "openmetadata-service/**"
- "openmetadata-ui/**"
- "openmetadata-spec/src/main/resources/json/schema/**"
- "openmetadata-dist/**"
- "openmetadata-clients/**"
- "common/**"
pull_request_target:
types: [labeled, opened, synchronize, reopened]
paths:
- "openmetadata-service/**"
- "openmetadata-ui/**"
- "openmetadata-spec/src/main/resources/json/schema/**"
- "openmetadata-dist/**"
- "openmetadata-clients/**"
- "common/**"

permissions:
contents: read
Expand All @@ -43,12 +33,14 @@ concurrency:
jobs:
test:
runs-on: ${{matrix.os}}

strategy:
matrix:
os:
- ubuntu-latest
node-version:
- 16.x

steps:

- name: Wait for the labeler
Expand All @@ -74,24 +66,13 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Cache Maven dependencies
id: cache-output
uses: actions/cache@v3
with:
path: ~/.m2
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
- name: Set up JDK 11
if: steps.cache-output.outputs.exit-code == 0
uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'adopt'

- name: Install Ubuntu dependencies
if: steps.cache-output.outputs.exit-code == 0
run: |
sudo apt-get update
sudo apt-get install -y unixodbc-dev python3-venv librdkafka-dev gcc libsasl2-dev build-essential libssl-dev libffi-dev \
Expand Down Expand Up @@ -124,7 +105,7 @@ jobs:

- name: Clean Up
run: |
cd ./docker/development
cd ./docker/local-metadata
docker compose down --remove-orphans
sudo rm -rf ${PWD}/docker-volume
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/py-checkstyle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:

- name: Install Ubuntu related dependencies
run: |
sudo apt-get update && sudo apt-get install -y libsasl2-dev unixodbc-dev python3-venv
sudo apt-get install -y libsasl2-dev unixodbc-dev python3-venv
- name: Install Python & Openmetadata related dependencies
run: |
Expand Down
Loading

0 comments on commit 007b74c

Please sign in to comment.