checking github action

Gururajj77 · Jan 11, 2024 · 369361d · 369361d
1 parent a5eea4f
commit 369361d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml
@@ -6,6 +6,10 @@ name: Deploy to Firebase Hosting on merge
   push:
     branches:
       - master
+
+env:
+  FIREBASE_CLI_EXPERIMENTS: webframeworks
+
 jobs:
   build_and_deploy:
     runs-on: ubuntu-latest
@@ -18,4 +22,3 @@ jobs:
           firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_BERVIPOST }}"
           channelId: live
           projectId: bervipost
-          env:FIREBASE_CLI_EXPERIMENTS: webframeworks
diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml
@@ -2,16 +2,16 @@
 # https://github.com/firebase/firebase-tools
 
 name: Deploy to Firebase Hosting on PR
-'on': pull_request
+"on": pull_request
 jobs:
   build_and_preview:
-    if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}'
+    if: "${{ github.event.pull_request.head.repo.full_name == github.repository }}"
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
       - run: npm ci && npm run build
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:
-          repoToken: '${{ secrets.GITHUB_TOKEN }}'
-          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_BERVIPOST }}'
+          repoToken: "${{ secrets.GITHUB_TOKEN }}"
+          firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_BERVIPOST }}"
           projectId: bervipost
diff --git a/src/app/feed/feed.component.html b/src/app/feed/feed.component.html
@@ -1,6 +1,6 @@
 <section class="feed-container">
-  <CustomButton [buttonName]="'Write'" (click)="openWrite()" />
-  <post-dialog [isDialogOpen]="openDialogBox" (closeWrite)="openWrite()" />
+  <CustomButton [buttonName]="'Write'" (click)="toggleWrite()" />
+  <post-dialog [isDialogOpen]="openDialogBox" (closeWrite)="toggleWrite()" />
   <h2 class="feed-title">News Feed</h2>
   <div class="feed-list">
     <div class="feed-item">

diff --git a/src/app/feed/feed.component.ts b/src/app/feed/feed.component.ts
@@ -15,7 +15,7 @@ export class FeedComponent {
 
   private readonly auth: Auth = inject(Auth);
   openDialogBox: boolean = false
-  openWrite() {
+  toggleWrite() {
     this.openDialogBox = !this.openDialogBox;
   }