feat: expand body colors to include neutrals and reduce secondary usage #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serikjensen
force-pushed
the
feat/GWS-5387
branch
from
b27ec17 to
c4ff217
Compare
serikjensen
changed the title
serikjensen
changed the title
jeffredodd
reviewed
Aug 13, 2025
| border-color: var(--g-colorSecondaryContent); | ||
| background: var(--g-colorSecondaryAccent); | ||
| opacity: 0.25; | ||
| cursor: not-allowed; |
There was a problem hiding this comment.
Just a gripe at CSS, why is this just not the default styling when the disabled attribute is present?
serikjensen
force-pushed
the
feat/GWS-5387
branch
from
c4ff217 to
26339a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to expand the colors for body colors and migrates most secondary colors (outside of button) to reference body colors instead.
The reasoning here is that body colors will be a better fit for most elements currently using secondary. Secondary might be considered a secondary brand color alongside primary, but we were using it before for things like neutral hover states just because it is gray in the SDK. If someone were to use secondary as another brand color it would look good for button but would have all sorts of cascading effects to things like typography.
Instead we update to use body colors for those instances. This means that changing secondary colors just updates the button, and body colors have more to do with UI elements such as lists/menus etc which are meant to have the body as the backdrop.
Proof of functionality