Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add option to switch on/off notification sound #233

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Mar 20, 2024

Historically DicoGIS plays a sound (Tkinter.bell) when the files/database processing ends to warn the user that he has to open the application to save the workbook.

This PR:

  • add an option to the GUI to enable/disable the notification sound
  • add an option to the CLI to enable/disable the notification sound
  • make this option settable with an environment variable
  • use a custom sound from BigSoundBank

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request ci-cd Everything related to continuous integration and deployment CLI Command Line Interface packaging labels Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@fad5cf4). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #233   +/-   ##
=========================================
  Coverage          ?   20.40%           
=========================================
  Files             ?       38           
  Lines             ?     3083           
  Branches          ?      318           
=========================================
  Hits              ?      629           
  Misses            ?     2422           
  Partials          ?       32           
Flag Coverage Δ
unittests 20.40% <8.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dicogis/__about__.py 100.00% <100.00%> (ø)
dicogis/ui/main_windows.py 0.00% <0.00%> (ø)
dicogis/cli/cmd_list.py 0.00% <0.00%> (ø)
dicogis/ui/tab_settings.py 20.45% <0.00%> (ø)
dicogis/utils/notifier.py 0.00% <0.00%> (ø)

@Guts Guts force-pushed the feature/add-option-to-switch-notification-sound branch from 5760b40 to b1f4d00 Compare March 20, 2024 18:35
@Guts Guts marked this pull request as ready for review March 20, 2024 18:45
@Guts Guts merged commit b9b84c9 into master Mar 20, 2024
8 checks passed
@Guts Guts deleted the feature/add-option-to-switch-notification-sound branch March 20, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Everything related to continuous integration and deployment CLI Command Line Interface documentation Improvements or additions to documentation enhancement New feature or request packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant