Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Postgis processing #287

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Fix: Postgis processing #287

merged 4 commits into from
Jun 4, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented May 31, 2024

No description provided.

@github-actions github-actions bot added bug Houston, we've a problem! CLI Command Line Interface labels May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 8.16327% with 45 lines in your changes missing coverage. Please review.

Project coverage is 24.40%. Comparing base (51f2a58) to head (ea189f9).

Current head ea189f9 differs from pull request most recent head b0d5426

Please upload reports for the commit b0d5426 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   26.24%   24.40%   -1.84%     
==========================================
  Files          40       40              
  Lines        2656     2667      +11     
  Branches      349      351       +2     
==========================================
- Hits          697      651      -46     
- Misses       1915     1972      +57     
  Partials       44       44              
Flag Coverage Δ
unittests 24.40% <8.16%> (-1.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dicogis/export/to_json.py 0.00% <ø> (ø)
dicogis/georeaders/read_postgis.py 64.70% <ø> (ø)
dicogis/ui/main_windows.py 0.00% <ø> (ø)
dicogis/utils/utils.py 35.21% <100.00%> (-0.90%) ⬇️
dicogis/georeaders/base_georeader.py 44.64% <50.00%> (+0.13%) ⬆️
dicogis/export/base_serializer.py 0.00% <0.00%> (-53.85%) ⬇️
dicogis/cli/cmd_inventory.py 0.00% <0.00%> (ø)
dicogis/export/to_xlsx.py 0.00% <0.00%> (-12.35%) ⬇️

@Guts Guts enabled auto-merge June 4, 2024 09:27
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Guts Guts merged commit e706543 into master Jun 4, 2024
7 of 8 checks passed
@Guts Guts deleted the fix/postgis-processing branch June 4, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Houston, we've a problem! CLI Command Line Interface quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant