Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(serializer): move serializer from parameters as class method of serializer meta class #298

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jun 6, 2024

No description provided.

@github-actions github-actions bot added the CLI Command Line Interface label Jun 6, 2024
@Guts Guts force-pushed the refacto/move-serializer-from-parameters-as-serializer-base-class-method branch from 0c407a3 to a0c966f Compare June 6, 2024 10:48
@Guts Guts enabled auto-merge June 6, 2024 10:48
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts added enhancement New feature or request and removed CLI Command Line Interface labels Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 23.76%. Comparing base (52c9313) to head (a0c966f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   23.72%   23.76%   +0.03%     
==========================================
  Files          41       41              
  Lines        2828     2824       -4     
  Branches      394      392       -2     
==========================================
  Hits          671      671              
+ Misses       2111     2107       -4     
  Partials       46       46              
Flag Coverage Δ
unittests 23.76% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dicogis/georeaders/process_files.py 0.00% <0.00%> (ø)
dicogis/cli/cmd_inventory.py 0.00% <0.00%> (ø)
dicogis/export/base_serializer.py 0.00% <0.00%> (ø)

@Guts Guts disabled auto-merge June 6, 2024 11:18
@Guts Guts merged commit edefe29 into master Jun 6, 2024
7 of 8 checks passed
@Guts Guts deleted the refacto/move-serializer-from-parameters-as-serializer-base-class-method branch June 6, 2024 11:18
@Guts Guts changed the title refacto(serializer): move serializer from paremeters as class method of serializer meta class refacto(serializer): move serializer from parameters as class method of serializer meta class Jun 6, 2024
@Guts Guts added the quality label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant