Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(gui): apply modernized code base to GUI launcher (which was broken) #300

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jun 6, 2024

No description provided.

@github-actions github-actions bot added bug Houston, we've a problem! CLI Command Line Interface labels Jun 6, 2024
@Guts Guts force-pushed the fix/gui-processing-was-broken branch from f2917a6 to 03fb2c1 Compare June 6, 2024 11:22
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts changed the title refacto(gui): apply modernized code base to GUI launcher refacto(gui): apply modernized code base to GUI launcher (which was broken) Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 23.84%. Comparing base (e0c823c) to head (f2917a6).
Report is 1 commits behind head on master.

Current head f2917a6 differs from pull request most recent head 03fb2c1

Please upload reports for the commit 03fb2c1 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   23.74%   23.84%   +0.10%     
==========================================
  Files          41       41              
  Lines        2826     2814      -12     
  Branches      393      391       -2     
==========================================
  Hits          671      671              
+ Misses       2108     2097      -11     
+ Partials       47       46       -1     
Flag Coverage Δ
unittests 23.84% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dicogis/georeaders/process_files.py 0.00% <0.00%> (ø)
dicogis/cli/cmd_inventory.py 0.00% <0.00%> (ø)
dicogis/ui/main_windows.py 0.00% <0.00%> (ø)
dicogis/export/base_serializer.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@Guts Guts merged commit 1a5aaf8 into master Jun 6, 2024
7 of 8 checks passed
@Guts Guts deleted the fix/gui-processing-was-broken branch June 6, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Houston, we've a problem! CLI Command Line Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant