ENH Use the core ArrayList Searchfilter functionality #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/2/use-core-searchfilter-arraylist
branch
from
a5c2384 to
450671c
Compare
|
Tests pass locally. Gotta figure out what's going on here, but there's no rush since 5.1.0 is still in beta. |
GuySartorelli
force-pushed
the
pulls/2/use-core-searchfilter-arraylist
branch
from
450671c to
0a7cca5
Compare
GuySartorelli
force-pushed
the
pulls/2/use-core-searchfilter-arraylist
branch
2 times, most recently
from
fdf9c37 to
31fd7f9
Compare
No need for the extra dependency after 5.1.0
GuySartorelli
force-pushed
the
pulls/2/use-core-searchfilter-arraylist
branch
from
31fd7f9 to
83c8727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for the extra dependency after 5.1.0
There's some minor changes needed for docs as well, which should have been done with 2.0.0