feat: Add validator that leverages symfony/validation constraints. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/2/constraints-validator
branch
3 times, most recently
from
8c971f9 to
e19a294
Compare
GuySartorelli
force-pushed
the
pulls/2/constraints-validator
branch
from
e19a294 to
e95f111
Compare
GuySartorelli
commented
Mar 19, 2024
There was a problem hiding this comment.
No point using a dedicated validator for this anymore - if you REALLY need regex validation, there's a constraint for that. But there may well be a constraint (or combination of constraints) to validate whatever you were validating in a cleaner way than regex (e.g. if you were checking IP addresses, use the Ip constraint) so check that before resorting to the regex constraint itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage the
symfony/validationsupport that's being added in Silverstripe CMS 5.2