Optional backwards compatibility with older clients #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
Aug 11, 2024
|
For reference, this is based on this code in NAGUS: |
dgelessus
suggested changes
Aug 11, 2024
Co-Authored-By: dgelessus <[email protected]>
The older client seems to want this for reasons that I don't fully care to investigate at the moment. It should be grabbing it from the GateKeeper, shouldn't it?
|
Is there anything remaining to do here before this can be merged? |
zrax
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, OU clients don't handle the Auth2Cli_ServerCaps message, and that results in the network stream getting into a bad state where the client throws an error and gives us.
This compatibility hack from dgelessus is interpreted as a ServerCaps response by newer clients that understand that message, and as a harmless file download response by older clients which don't.