Fix #3 support elasticsearch-dsl-py v6.4 and fix bug in es-list - PD-25495 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codekiln
changed the title
codekiln
changed the title
codekiln
commented
Jul 12, 2023
django_elastic_migrations/indexes.py
Outdated
| if index is None: | ||
| index = self.get_dem_index().get_es_index_name() | ||
| if index is None: | ||
| index = super(DEMDocType, self)._get_index(index, required) |
There was a problem hiding this comment.
This is the main workaround needed to get this to work in v6.2+
aHardReset
approved these changes
Jul 12, 2023
…t-elasticsearch-dsl-6 # Conflicts: # Makefile
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 72.02% 72.06% +0.04%
==========================================
Files 20 20
Lines 1594 1600 +6
Branches 243 244 +1
==========================================
+ Hits 1148 1153 +5
Misses 358 358
- Partials 88 89 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
codekiln
changed the title
mn/#3-support-latest-elasticsearch-dsl-6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #3 and #96.
Renamed DEMDocType to DEMDocument to reflect the underlying change in elasticsearch-dsl-py 6.2.