Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSDN url for each test in html report #259

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Add MSDN url for each test in html report #259

merged 3 commits into from
Oct 7, 2023

Conversation

kostyanf14
Copy link
Contributor

No description provided.

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14 kostyanf14 requested a review from akihikodaki October 3, 2023 17:00
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report_data now modifies tests, which does not look like a good idea.

  • For example, consider that you are adding a new feature that outputs the URLs in the future. You would naturally pp playlist.test to inspect the test data, find the url property, and use it. Later, you will no longer need an HTML output so remove the call to report_data. When you do so, it accidentally breaks the irrelevant URL output you have added earlier.
  • This computes URLs twice in print_tests and report_data, but you don't really have to when you are storing URLs.

A possible alternative way is to store URLs in AutoHCK::Playlist#list_tests. This way, you can always expect tests to include URLs.

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@YanVugenfirer YanVugenfirer merged commit fec8254 into master Oct 7, 2023
@YanVugenfirer YanVugenfirer deleted the test-url branch October 7, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants