Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "time_to_second" helper #300

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix "time_to_second" helper #300

merged 1 commit into from
Feb 14, 2024

Conversation

Jedoku
Copy link
Contributor

@Jedoku Jedoku commented Feb 12, 2024

No description provided.

Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests if you are not in a hurry. Use the test cases from .NET:
https://github.com/dotnet/runtime/blob/v8.0.1/src/libraries/System.Memory/tests/ParsersAndFormatters/Parser/TestData.Parser.TimeSpan.cs#L181-L206

You don't need to test the cases of leading whitespaces, negative values, and illegal cases. Such cases should never happen.

lib/auxiliary/time_helper.rb Outdated Show resolved Hide resolved
lib/auxiliary/time_helper.rb Outdated Show resolved Hide resolved
lib/auxiliary/time_helper.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the Fix-time-1-00-00-00-parse branch from b98b042 to 7f3dfe9 Compare February 13, 2024 10:43
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

spec/lib/auxiliary/test_helper_spec.rb Outdated Show resolved Hide resolved
spec/lib/auxiliary/test_helper_spec.rb Outdated Show resolved Hide resolved
spec/lib/auxiliary/test_helper_spec.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the Fix-time-1-00-00-00-parse branch from f956c24 to 8e065cd Compare February 13, 2024 15:37
lib/auxiliary/time_helper.rb Outdated Show resolved Hide resolved
spec/lib/auxiliary/test_helper_spec.rb Outdated Show resolved Hide resolved
spec/lib/auxiliary/test_helper_spec.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the Fix-time-1-00-00-00-parse branch 2 times, most recently from 7de986f to 9aaaf50 Compare February 13, 2024 16:38
@kostyanf14
Copy link
Contributor

@Jedoku LGTM

Please combine all your changes into one or two commits. For each review iteration, you should fix the original commits.

@Jedoku Jedoku force-pushed the Fix-time-1-00-00-00-parse branch 2 times, most recently from 4038876 to 60b63bb Compare February 14, 2024 07:53
@kostyanf14
Copy link
Contributor

@Jedoku You missed Signed-off-by in commit

Signed-off-by: Vitalii Chulak <[email protected]>
@Jedoku Jedoku force-pushed the Fix-time-1-00-00-00-parse branch from 60b63bb to deefaf7 Compare February 14, 2024 08:26
@kostyanf14 kostyanf14 merged commit 69f3431 into master Feb 14, 2024
5 checks passed
@kostyanf14 kostyanf14 deleted the Fix-time-1-00-00-00-parse branch February 14, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants