-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoHCK fail when rerun test with BSOD #303
Conversation
66b5afc
to
b271e63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have an explanation for me, who doesn't know the context? For me, it looks immune against collisions even without a timestamp since the zip has the id.
Why did you use id instead of timestamp? It's inconsistent.
If you really need timestsamps, extract AutoHCK::Project#create_timestamp
into a helper and change this to use it.
@akihikodaki When we start a test with a dump twice, we have to save both dumps into a zip archive. The problem arises when we save a folder with the name of the client's VM (CL01 in this case) into the zip file. When we try to add the folder a second time, we receive an error stating that the folder already exists. The solution to this issue involves adding a timestamp to the folder name, allowing us to circumvent the problem. |
@Jedoku I see. Thanks for the explanation. |
9c32e19
to
561368a
Compare
561368a
to
994af1b
Compare
994af1b
to
38b96a7
Compare
Signed-off-by: Vitalii Chulak <[email protected]>
38b96a7
to
cdfc37d
Compare
Resolves: #254