Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoHCK fail when rerun test with BSOD #303

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

Jedoku
Copy link
Contributor

@Jedoku Jedoku commented Feb 15, 2024

Resolves: #254

lib/engines/hcktest/tests.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the AutoHCK-fail-when-rerun-test-with-BSOD branch from 66b5afc to b271e63 Compare February 16, 2024 03:59
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have an explanation for me, who doesn't know the context? For me, it looks immune against collisions even without a timestamp since the zip has the id.

Why did you use id instead of timestamp? It's inconsistent.
If you really need timestsamps, extract AutoHCK::Project#create_timestamp into a helper and change this to use it.

@Jedoku
Copy link
Contributor Author

Jedoku commented Feb 17, 2024

Can you have an explanation for me, who doesn't know the context? For me, it looks immune against collisions even without a timestamp since the zip has the id.

Why did you use id instead of timestamp? It's inconsistent. If you really need timestsamps, extract AutoHCK::Project#create_timestamp into a helper and change this to use it.

@akihikodaki When we start a test with a dump twice, we have to save both dumps into a zip archive. The problem arises when we save a folder with the name of the client's VM (CL01 in this case) into the zip file. When we try to add the folder a second time, we receive an error stating that the folder already exists. The solution to this issue involves adding a timestamp to the folder name, allowing us to circumvent the problem.

@akihikodaki
Copy link
Contributor

@Jedoku I see. Thanks for the explanation.

lib/auxiliary/time_helper.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the AutoHCK-fail-when-rerun-test-with-BSOD branch from 9c32e19 to 561368a Compare February 21, 2024 13:17
lib/auxiliary/time_helper.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the AutoHCK-fail-when-rerun-test-with-BSOD branch from 561368a to 994af1b Compare February 21, 2024 16:19
@Jedoku Jedoku requested a review from kostyanf14 February 21, 2024 16:44
lib/engines/hcktest/tests.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the AutoHCK-fail-when-rerun-test-with-BSOD branch from 994af1b to 38b96a7 Compare February 22, 2024 12:59
@Jedoku Jedoku force-pushed the AutoHCK-fail-when-rerun-test-with-BSOD branch from 38b96a7 to cdfc37d Compare February 22, 2024 13:48
@Jedoku Jedoku requested a review from akihikodaki February 22, 2024 14:26
@YanVugenfirer YanVugenfirer merged commit 297b7b3 into master Feb 25, 2024
5 checks passed
@YanVugenfirer YanVugenfirer deleted the AutoHCK-fail-when-rerun-test-with-BSOD branch February 25, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoHCK fail when rerun test with BSOD
4 participants