Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop JSON Type Definition #322

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Drop JSON Type Definition #322

merged 1 commit into from
Mar 17, 2024

Conversation

kostyanf14
Copy link
Contributor

JTD was replaced with Sorbet.

akihikodaki
akihikodaki requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove check for jtd.json from spec/srb_json_load_spec.rb as well.

@kostyanf14
Drop JSON Type Definition
91aa1c1 
JTD was replaced with Sorbet.

Signed-off-by: Konstantin Kostiuk <[email protected]>
@kostyanf14 kostyanf14 requested a review from akihikodaki March 15, 2024 07:57
@YanVugenfirer YanVugenfirer merged commit bf594f3 into HCK-CI:master Mar 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihikodaki akihikodaki akihikodaki approved these changes

@YanVugenfirer YanVugenfirer YanVugenfirer approved these changes

@Jedoku Jedoku Awaiting requested review from Jedoku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostyanf14 @YanVugenfirer @akihikodaki