Support HCK installer as ISO

[Jedoku]

Script side HCK-CI/HLK-Setup-Scripts#20

[akihikodaki]

Instead of requiring to specify iso flag, why not automatically detect it?
If File.read(path, 2) == 'MZ', it is a Windows executable. You can assume a disk image otherwise.

[Jedoku]

Instead of requiring to specify iso flag, why not automatically detect it? If File.read(path, 2) == 'MZ', it is a Windows executable. You can assume a disk image otherwise.

Yeah, we think about it, but for get extention you need to download file from link and check it then somehow save it to another folder it was easiest way to done this task. We use curb gem for done this and with provided links it`s impossible to get filename before downloading and you also should save it with filename.

[akihikodaki]

Instead of requiring to specify iso flag, why not automatically detect it? If File.read(path, 2) == 'MZ', it is a Windows executable. You can assume a disk image otherwise.

Yeah, we think about it, but for get extention you need to download file from link and check it then somehow save it to another folder it was easiest way to done this task. We use curb gem for done this and with provided links it`s impossible to get filename before downloading and you also should save it with filename.

Just download it without an extension and rename it.

[akihikodaki]

• It's better to use httpclient or faraday gem if you are going to read HTTP headers. Note that these gems are already used by other dependencies, so requiring them does not add more dependencies.
• Don't perform HTTP requests twice. I bet it doesn't need much code to save one HTTP request.

[akihikodaki]

Also see: #325 (comment)

[kostyanf14]

Let's use move-specific EngineError