-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transfer_net common options #354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyanf14
requested changes
Apr 25, 2024
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
April 29, 2024 16:29
75d3db7
to
91a992d
Compare
Jedoku
commented
Apr 29, 2024
akihikodaki
requested changes
Apr 30, 2024
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
April 30, 2024 18:08
91a992d
to
3a4957b
Compare
akihikodaki
requested changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep names consistent; the same thing should not be called two different names, share_host_directory
and share_on_host_path
.
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
May 1, 2024 18:37
3a4957b
to
b273457
Compare
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
May 1, 2024 20:00
b273457
to
aa2abb7
Compare
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
May 7, 2024 11:03
aa2abb7
to
933f1a0
Compare
akihikodaki
requested changes
May 8, 2024
kostyanf14
requested changes
May 8, 2024
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
May 12, 2024 19:46
933f1a0
to
8fb5e58
Compare
kostyanf14
reviewed
May 13, 2024
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
May 15, 2024 21:51
8fb5e58
to
929bbe4
Compare
kostyanf14
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akihikodaki Please review
akihikodaki
requested changes
May 20, 2024
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
May 21, 2024 15:08
929bbe4
to
00e41d6
Compare
akihikodaki
requested changes
May 23, 2024
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
May 27, 2024 05:21
00e41d6
to
935669b
Compare
akihikodaki
requested changes
Jun 4, 2024
…-share-on-host-path <path>" Signed-off-by: Vitalii Chulak <[email protected]>
Jedoku
force-pushed
the
Add-transfer_net-common-options
branch
from
June 7, 2024 13:19
935669b
to
c6e2951
Compare
akihikodaki
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.