Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transfer_net common options #354

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Jedoku
Copy link
Contributor

@Jedoku Jedoku commented Apr 25, 2024

No description provided.

lib/cli.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from 75d3db7 to 91a992d Compare April 29, 2024 16:29
lib/cli.rb Outdated Show resolved Hide resolved
lib/cli.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from 91a992d to 3a4957b Compare April 30, 2024 18:08
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep names consistent; the same thing should not be called two different names, share_host_directory and share_on_host_path.

lib/setupmanagers/qemuhck/qemuhck.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from 3a4957b to b273457 Compare May 1, 2024 18:37
@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from b273457 to aa2abb7 Compare May 1, 2024 20:00
@Jedoku Jedoku requested a review from akihikodaki May 2, 2024 07:58
@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from aa2abb7 to 933f1a0 Compare May 7, 2024 11:03
lib/setupmanagers/qemuhck/qemuhck.rb Outdated Show resolved Hide resolved
lib/setupmanagers/qemuhck/qemuhck.rb Outdated Show resolved Hide resolved
lib/setupmanagers/qemuhck/qemu_machine.rb Outdated Show resolved Hide resolved
lib/cli.rb Show resolved Hide resolved
lib/setupmanagers/qemuhck/qemu_machine.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from 933f1a0 to 8fb5e58 Compare May 12, 2024 19:46
@Jedoku Jedoku requested review from akihikodaki and kostyanf14 May 13, 2024 01:56
lib/cli.rb Show resolved Hide resolved
@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from 8fb5e58 to 929bbe4 Compare May 15, 2024 21:51
@Jedoku Jedoku requested a review from kostyanf14 May 16, 2024 08:12
Copy link
Contributor

@kostyanf14 kostyanf14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihikodaki Please review

@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from 929bbe4 to 00e41d6 Compare May 21, 2024 15:08
@Jedoku Jedoku requested a review from akihikodaki May 23, 2024 05:15
lib/setupmanagers/qemuhck/qemuhck.rb Outdated Show resolved Hide resolved
@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from 00e41d6 to 935669b Compare May 27, 2024 05:21
@Jedoku Jedoku requested a review from akihikodaki June 4, 2024 09:18
lib/setupmanagers/qemuhck/qemuhck.rb Outdated Show resolved Hide resolved
…-share-on-host-path <path>"

Signed-off-by: Vitalii Chulak <[email protected]>
@Jedoku Jedoku force-pushed the Add-transfer_net-common-options branch from 935669b to c6e2951 Compare June 7, 2024 13:19
@Jedoku Jedoku requested a review from akihikodaki June 10, 2024 07:04
@YanVugenfirer YanVugenfirer merged commit a20c5cb into master Jun 10, 2024
6 checks passed
@YanVugenfirer YanVugenfirer deleted the Add-transfer_net-common-options branch June 10, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants