Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the meaning of manual mode #359

Merged
merged 8 commits into from
May 11, 2024
Merged

Change the meaning of manual mode #359

merged 8 commits into from
May 11, 2024

Conversation

kostyanf14
Copy link
Contributor

No description provided.

@kostyanf14 kostyanf14 changed the title Change the meaning of manual mode RFC: Change the meaning of manual mode Apr 30, 2024
akihikodaki
akihikodaki requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it may be a good time to rename dump_only to dump. dump_only sounds as if AutoHCK usually dumps commands and run them and the option is to perform only command dumping, but in reality, command dumps are generated only when the option is specified.

lib/engines/hcktest/hcktest.rb Outdated Show resolved Hide resolved
lib/engines/hcktest/hcktest.rb Outdated Show resolved Hide resolved
@kostyanf14
CLI: Rename manual mode to dump mode
d5b3c5a 
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14 kostyanf14 requested a review from akihikodaki May 7, 2024 08:31
@kostyanf14 kostyanf14 changed the title RFC: Change the meaning of manual mode Change the meaning of manual mode May 7, 2024
@kostyanf14 kostyanf14 requested a review from Jedoku May 7, 2024 10:58
akihikodaki
akihikodaki requested changes May 9, 2024
View reviewed changes
lib/engines/hcktest/hcktest.rb Outdated Show resolved Hide resolved
kostyanf14 added 7 commits May 10, 2024 18:17
@kostyanf14
hcktest: Reimplement manual mode
09002f9 
Stay in loop after all the tests are done

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14
playlist: Add default value for rejected_test
2519792 
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14
playlist: Allow target to be nil
09dfbee 
When no target present, return empty tests lists.

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14
hckclient: Log when client preparation skipped
97c2954 
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14
hcktest: Skip client preparation in manual mode without driver path
1b9fa18 
This code is not called in dump mode, no need to check it.

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14
hcktest: Initialize tests in engine instead of setupmanager
056a6f2 
This get more flexebility during initialization of manual mode.

Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14
tests: Add default value for tests
3ad0d55 
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14 kostyanf14 requested a review from akihikodaki May 10, 2024 17:15
@kostyanf14 kostyanf14 merged commit a2c1713 into HCK-CI:master May 11, 2024
6 checks passed
@kostyanf14 kostyanf14 deleted the manual branch May 11, 2024 17:58
@akihikodaki
Copy link
Contributor

For Binding#irb, opened: sorbet/sorbet#7889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihikodaki akihikodaki akihikodaki approved these changes

@Jedoku Jedoku Awaiting requested review from Jedoku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostyanf14 @akihikodaki @Jedoku