-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for S3-compatible storage in Result Uploader #476
Add support for S3-compatible storage in Result Uploader #476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review and fix Rubocop code scanning error too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thank you for your contribution.
Please consider using AWS SDK instead; it should give chances to support many S3-compatible storages, including Alibaba Cloud OSS. If you definitely need a feature specific to Alibaba Cloud OSS, please explain it.
@akihikodaki , Thank you for your valuable suggestion! I chose the Alibaba Cloud SDK primarily because I work with Alibaba Cloud, which makes maintenance and troubleshooting more convenient for me. I hadn't fully considered the potential benefits of using the AWS SDK, as I usually select the SDK that corresponds to the cloud service I'm utilizing. I do have a question regarding the definition of "result uploader." Currently, we are using Dropbox, and my initial understanding was that each storage service would have its own dedicated "result uploader," such as Dropbox, Alibaba Cloud OSS, AWS Storage, etc. Is this understanding correct? In other words, even though they are all S3-compatible storages, will there still be individual result uploaders for different products from various companies? I would appreciate your insight on whether you envision S3-compatible storages as being treated as a single result uploader. |
We agree with the idea of having one S3-compatible result uploader with the ability to configure it for AWS, Alibaba Cloud, or even open-source storage (e.g., minio). |
@kostyanf14 Got it. I have turned the patch into a draft as I need some time to modify and test it |
28dd168
to
784b42d
Compare
Signed-off-by: Zhang JianMing [email protected]
@kostyanf14 Could you please reopen my patch? I accidentally closed it while resetting the branch, and I didn’t see the option to reopen it afterward. I’m not sure if this is due to permission issues. |
@zjmletang I reopened |
@zjmletang Can I make PR ready for review? |
@kostyanf14. Not ready yet; I haven't tested it thoroughly myself. I'll notify you once I finish the testing |
bce5d51
to
b4f5b97
Compare
@kostyanf14 , I am ready on my side. Please see the configuration document below To upload files using S3-Compatible storage (supports AWS S3, Alibaba Cloud OSS, etc.), please follow the steps below for configuration:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer it to be named S3 instead of S3compatible for conciseness. Anything compatible with S3 should work with an uploader for S3 anyway so "compatible" adds no semantic value.
b4f5b97
to
c43994a
Compare
c43994a
to
b0f0a16
Compare
b0f0a16
to
7ca5839
Compare
7ca5839
to
9655726
Compare
dd86ca9
to
1edecdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few nits remaining and this pull request will be ready once they are handled. Thank you for keeping working on this feature!
- Implemented support for S3-compatible cloud storage, including but not limited to AWS S3, Alibaba Cloud OSS, and others. For the problem description, please visit HCK-CI#471 Signed-off-by: Zhang JianMing [email protected]
1edecdb
to
480e44e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now all my feedback is addressed. Thank you for your contribution!
I have made the changes. Thank you very much for your thorough guidance; I have learned a lot @akihikodaki @kostyanf14 @YanVugenfirer |
To upload files using Alibaba Cloud OSS, you must first have an Alibaba Cloud OSS account, which includes your Access Key (AK) and Secret Key (SK). Once you have these, please follow the steps below for configuration:
export AUTOHCK_ALICLOUDOSS_ACCESS_KEY_ID=<AK>
export AUTOHCK_ALICLOUDOSS_CLIENT_SECRET=<SK>
After completing these steps, you'll be ready to upload files to Alibaba Cloud OSS.
for the problem description
please visit #471
Signed-off-by: Zhang JianMing [email protected]