Bring up previous session #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jedoku
force-pushed
the
Add-ability-to-bring-up-previous-session
branch
2 times, most recently
from
a94ca1f to
71d5c6c
Compare
|
I'm not a fan of this idea. It brings significant complexity similar to |
Jedoku
force-pushed
the
Add-ability-to-bring-up-previous-session
branch
from
71d5c6c to
7e1ff8a
Compare
akihikodaki
requested changes
Oct 19, 2024
| @@ -581,6 +582,8 @@ def save_run_script(file_name, file_content) | |||
|
|
|||
| def run_config_commands | |||
| device_config_commands.each do |dirty_cmd| | |||
| next if dirty_cmd.include?('@swtpm_setup_bin@') && @run_opts[:reuse_tpm] | |||
There was a problem hiding this comment.
Figure out how to handle this in a generic manner instead of introducing a special handling.
Jedoku
force-pushed
the
Add-ability-to-bring-up-previous-session
branch
from
7e1ff8a to
8a79a7e
Compare
akihikodaki
requested changes
Dec 3, 2024
Signed-off-by: Vitalii Chulak <[email protected]>
Jedoku
force-pushed
the
Add-ability-to-bring-up-previous-session
branch
from
8a79a7e to
0ba68bc
Compare
akihikodaki
requested changes
Dec 19, 2024
Comment on lines
+17
to
+39
| cli.test.platform = session.test.platform | ||
| cli.test.drivers = session.test.drivers | ||
| cli.test.driver_path ||= session.test.driver_path | ||
| cli.test.commit ||= session.test.commit | ||
| cli.test.svvp = session.test.svvp | ||
| cli.test.dump ||= session.test.dump | ||
| cli.test.gthb_context_prefix ||= session.test.gthb_context_prefix | ||
| cli.test.gthb_context_suffix ||= session.test.gthb_context_suffix | ||
| cli.test.playlist ||= session.test.playlist | ||
| cli.test.select_test_names ||= session.test.select_test_names | ||
| cli.test.reject_test_names ||= session.test.reject_test_names | ||
| cli.test.reject_report_sections ||= session.test.reject_report_sections | ||
| cli.test.boot_device ||= session.test.boot_device | ||
| cli.test.allow_test_duplication ||= session.test.allow_test_duplication | ||
| cli.test.manual ||= true | ||
| cli.test.package_with_playlist |= session.test.package_with_playlist | ||
| cli.test.session = session_path(cli) | ||
| cli.test.latest_session ||= session.test.latest_session | ||
| cli.common.verbose ||= session.common.verbose | ||
| cli.common.config ||= session.common.config | ||
| cli.common.client_world_net ||= session.common.client_world_net | ||
| cli.common.id ||= session.common.id | ||
| cli.common.share_on_host_path ||= session.common.share_on_host_path |
There was a problem hiding this comment.
What about just assigning session.test to cli.test instead of listing every properties here?
Comment on lines
+47
to
+50
| { | ||
| test: options.test.serialize, | ||
| common: options.common.serialize | ||
| }.to_json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP