Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespace configuration for h5pyd #187

Merged
merged 9 commits into from
Apr 29, 2024
Merged

Add codespace configuration for h5pyd #187

merged 9 commits into from
Apr 29, 2024

Conversation

jreadey
Copy link
Member

@jreadey jreadey commented Apr 26, 2024

This PR enables h5pyd to be run as a github codespace.
Test suite should be runable within the codespace as well as scripts/notebooks under examples.

@jreadey jreadey requested a review from mattjala April 26, 2024 17:16
@@ -0,0 +1 @@
{"owner": "admin", "acls": {"admin": {"create": true, "read": true, "update": true, "delete": true, "readACL": true, "updateACL": true}, "default": {"create": false, "read": true, "update": false, "delete": false, "readACL": false, "updateACL": false}}, "created": 1708897646.0599918, "lastModified": 1708897646.0599918}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the hsds/data folder was included by accident.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@jreadey
Copy link
Member Author

jreadey commented Apr 29, 2024

hsds is installed as part of the codespace. You can run hsinfo in the codespace terminal and see it connecting to http://localhost:5101.

Copy link
Contributor

@mattjala mattjala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreadey jreadey merged commit 5710666 into master Apr 29, 2024
10 checks passed
@jreadey jreadey deleted the codespace branch April 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants