Fix variable usage to reduce conflicts with hdf5 library #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
changed the title
| # Build examples | ||
| #----------------------------------------------------------------------------- | ||
| add_subdirectory (C) | ||
| if (HDF_BUILD_FORTRAN AND HDF5_BUILD_FORTRAN) |
There was a problem hiding this comment.
It would be good to update these variable names to use a prefix like "H5EX" or "HDF5EX" as used above so that we know where the variables come from and what they're used for. It would also be good to decide which among "H5EX" and "HDF5EX" we wish to use and try to be consistent using that every across these CMakeLists files for the examples.
lrknox
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not calculate version if included in library
add_subdirectory commands should be after checking for requirements
Correct names and variables
Change project specific variables to not clash with HDF5 library names