Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] HDF5_BUILD_FORTRAN:BOOL=OFF ->HDF5_TEST_FORTRAN:BOOL=ON ? #2781

Closed
hyoklee opened this issue Apr 20, 2023 · 4 comments
Closed

[BUG] HDF5_BUILD_FORTRAN:BOOL=OFF ->HDF5_TEST_FORTRAN:BOOL=ON ? #2781

hyoklee opened this issue Apr 20, 2023 · 4 comments
Assignees
Labels
Component - Build CMake, Autotools

Comments

@hyoklee
Copy link
Member

hyoklee commented Apr 20, 2023

Describe the bug
I ran the generic mkdir build && cd build && cmake ...

It's strange to see

//Execute fortran tests
HDF5_TEST_FORTRAN:BOOL=ON

//Execute java tests
HDF5_TEST_JAVA:BOOL=ON

in build/CMakeCache.txt.

Expected behavior

I think they should be OFF.

Platform (please complete the following information)

  • HDF5 version: develop branch
  • OS and version: Linux login13 5.14.21-150400.24.46_12.0.63-cray_shasta_c #1 SMP Fri Mar 3 22:39:37 UTC 2023 (6e164f9) x86_64 x86_64 x86_64 GNU/Linux
  • Compiler and version: n/a
  • Build system: CMake 3.20.4
  • Any configure options you specified: n/a
  • MPI library and version (parallel HDF5): n/a
@byrnHDF
Copy link
Contributor

byrnHDF commented Apr 20, 2023

HDF5_TEST_xxx are dependent on HDF5_BUILD_xxx and will only be applicable if the BUILD is enabled. Dependent defaults are the state expected if they apply. Normal expectation is that if one enables a language and testing is enabled then the language tests should run.

@byrnHDF byrnHDF self-assigned this Apr 20, 2023
@byrnHDF byrnHDF added the Component - Build CMake, Autotools label Apr 20, 2023
@byrnHDF
Copy link
Contributor

byrnHDF commented Apr 20, 2023

What is missing is the section in INSTALL_CMake.txt that should list those HDF5_TEST_xxx options

@byrnHDF
Copy link
Contributor

byrnHDF commented May 2, 2023

doc file updated

@byrnHDF byrnHDF closed this as completed May 2, 2023
@hyoklee
Copy link
Member Author

hyoklee commented May 2, 2023

Where is the commit hash / PR that refers this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build CMake, Autotools
Projects
None yet
Development

No branches or pull requests

2 participants