Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct CMake option defaults - deprecate szip for libaec #2778

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Correct CMake option defaults - deprecate szip for libaec #2778

merged 3 commits into from
Apr 23, 2023

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Apr 19, 2023

Updated the default state for some options referenced elsewhere.
libaec has been the default for a few years and removing the option for the old szip library simplifies usage.

@byrnHDF byrnHDF added Merge - To 1.14 Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - Documentation Doxygen, markdown, etc. Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately labels Apr 19, 2023
@byrnHDF byrnHDF self-assigned this Apr 19, 2023
hyoklee
hyoklee requested changes Apr 20, 2023
View reviewed changes
release_docs/RELEASE.txt Outdated
@@ -47,6 +47,11 @@ New Features

Configuration:
-------------
- Deprecate and remove old SZIP library in favor of LIBAEC library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use past tense for consistency - Deprecated.

Copy link
Collaborator

@lrknox lrknox Apr 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated and removed ...
and maybe "We removed the options in the sentence below.

@derobins derobins merged commit 3f5842c into HDFGroup:develop Apr 23, 2023
@byrnHDF byrnHDF deleted the develop-cmake-opts branch April 28, 2023 15:55
@byrnHDF
Copy link
Contributor Author

byrnHDF commented May 2, 2023

Fixes #2781

brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request May 17, 2023
@byrnHDF @brtnfld
Correct CMake option defaults - deprecate szip for libaec (HDFGroup#2778
12a78a5 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjala mattjala mattjala approved these changes

@lrknox lrknox lrknox approved these changes

@hyoklee hyoklee hyoklee approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Documentation Doxygen, markdown, etc. Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Type - Improvement Improvements that don't add a new feature or functionality
Projects
Downstream HDF5 Merges
Status: Needs Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@byrnHDF @hyoklee @lrknox @mattjala @derobins