Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test decreasing and then increasing size of dset #267

Closed
wants to merge 1 commit into from

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Oct 6, 2023

After decreasing and then increasing size, the new positions in the dataset should have a value equal to fill value, not whatever was written there before the size was decreased.

@jreadey
Copy link
Member

jreadey commented Oct 9, 2023

That behavior will require quite a bit more additional logic.
Let's push this PR to master and then work on the value changes in separate PR.
It will be a good place to include the TBD code to remove chunks that are no longer part of the dataspace.

@mattjala
Copy link
Contributor Author

More comprehensive tests for this are added in #277

@mattjala mattjala closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants