group post with h5path option #302
Conversation
hsds/servicenode_lib.py
Outdated
| bucket=None): | ||
|
|
||
| """ create the group at the designated path relative to the parent. | ||
| If implicit is True, make any intermidiate groups needed in the h5path. """ |
There was a problem hiding this comment.
intermidiate -> intermediate
| @@ -1006,3 +1011,116 @@ async def deleteObj(app, obj_id, bucket=None): | |||
| meta_cache = app["meta_cache"] | |||
| if obj_id in meta_cache: | |||
| del meta_cache[obj_id] # remove from cache | |||
|
|
|||
|
|
|||
| async def createGroup(app, root_id=None, creation_props=None, bucket=None): | |||
There was a problem hiding this comment.
Since the parent group that will contain the new group doesn't have to be the root group, root_id should be renamed to parent_id
There was a problem hiding this comment.
This method is for anonymous group so parent I’d wouldn’t apply. The root I’d basically determines which domain the group will belong to
| link_id = None | ||
| link_title = None | ||
| # allow parent group creation or not | ||
| implicit = getBooleanParam(params, "implicit") |
There was a problem hiding this comment.
Whether or not to create intermediate groups is specified in the creation properties of a group - see docs here. Would it be possible to read this from provided creation properties instead?
There was a problem hiding this comment.
How about we have the rest vol inspect the property list and set the query param if it applies?
Add h5path option to post groups