Hyperchunk2d #310
Merged
Hyperchunk2d #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
reviewed
Feb 15, 2024
hsds/dset_lib.py
Outdated
| arr_points[idx] = pt | ||
| else: | ||
| kwargs = {"dim": dim + 1, "chunk_index": chunk_index, "factors": factors} | ||
| next_index = arr_index + (i * np.prod(factors[1:])) |
There was a problem hiding this comment.
Should this use np.prod(factors[i:]) to account for all remaining dimensions? This might not matter right now since hyperchunking is limited to two dimensions at most, but it would be easier to understand and future-proof
There was a problem hiding this comment.
Yes this is a bug that shows up with more than two dimensions. Fixed this and add a 3D test. Should work for any number of dimensions now
mattjala
reviewed
Feb 15, 2024
hsds/util/rangegetUtil.py
Outdated
| @@ -20,6 +21,37 @@ def _chunk_start(c): | |||
| return start | |||
|
|
|||
|
|
|||
| def getHyperChunkFactors(chunk_dims, hyper_dims): | |||
| """ return list of rations betwen chunk and hyperchunkdims """ | |||
mattjala
reviewed
Feb 15, 2024
| @@ -66,6 +67,41 @@ def getFillValue(dset_json): | |||
| return arr | |||
|
|
|||
|
|
|||
| def _get_arr_pts(arr_points, arr_index, pt, dim=0, chunk_index=None, factors=None): | |||
| """ recursive function to fill in chunk locations for hyperchunk selection. | |||
| arr_points: numpy array of shape (num_chunks, rank) | |||
There was a problem hiding this comment.
Might be more clear to reword this to something like Recursive function which fills arr_points with the coordinates to locate a hyperchunk selection's corresponding chunks in a chunk table.
mattjala
reviewed
Feb 15, 2024
hsds/chunk_dn.py
Outdated
| else: | ||
| hyper_index = param_hyper_index | ||
| log.debug(f"hyper_index: {hyper_index}") | ||
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hyperchunking support for multi-dimensional datasets.