Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scan timeout on Windows #355

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Apr 22, 2024

After #349, Windows still sometimes has a scan timeout due to getNow inaccuracy between nodes. This reverts the scan timestamps to use time.time(). Because the scan check now accepts an equal timestamp as satisfying the scan request, the inaccuracy of time.time() shouldn't be a problem in this case.

@mattjala mattjala added bug ci/cd Issues related to the CI/CD setup and execution labels Apr 22, 2024
@mattjala mattjala requested a review from jreadey April 22, 2024 16:12
@mattjala mattjala self-assigned this Apr 22, 2024
Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jreadey jreadey merged commit b712200 into HDFGroup:master Apr 23, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci/cd Issues related to the CI/CD setup and execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants