Support long links with HSDS >0.8.5 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
force-pushed
the
long_link_support
branch
from
6db32f0
to
d8e46c9
Compare
mattjala
force-pushed
the
long_link_support
branch
from
df0d22b
to
5cbc938
Compare
|
|
||
| /* Necessary to prevent curl from potentially accessing freed buffers in subsequent calls */ | ||
| if (CURLE_OK != curl_easy_setopt(curl, CURLOPT_POST, 0)) | ||
| FUNC_GOTO_ERROR(H5E_LINK, H5E_CANTSET, FAIL, "can't unset cURL HTTP POST request: %s", curl_err_buf); |
There was a problem hiding this comment.
Should switch this to a FUNC_DONE_ERROR
jhendersonHDF
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDFGroup/hsds#296 (not yet complete) adds API endpoints which allow link names to be provided in the body of a POST request, rather than through the URL. This branch changes some operations (
RV_link_create,RV_link_specific,RV_find_object_by_path) to use the newer API if it is available.Callbacks for
RV_find_object_by_pathwere changed to handle a potential top-levelh5pathskey if the initial request was a plural attributes/links request.RV_get_object_info_callbackneeds the hrefs in the response to get the object's domain/file, and these hrefs aren't returned for links/attributes requests. Another change to the HSDS API (returning the domain for each link/attr?) is still needed to resolve this.