Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake to build under library #56

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

mattjala
Copy link
Collaborator

@mattjala mattjala commented Aug 30, 2023

Depends on the changes to CMakeVOL.cmake from HDFGroup/hdf5#3450

  • REST VOL must now be built at library build time with CMake, as described in the README
  • Removed build scripts, autotools files, and PREBUILT_HDF5_DIR options.
  • Removed hdf5 and vol-tests submodules (recent additions and outstanding PRs to vol-tests will need to get merged to HDF5's API tests).
  • CI workflow now uses ctest to run the test_rest_vol file with valgrind.
  • README describes updated build process

@mattjala mattjala added the enhancement New feature or request label Aug 30, 2023
@mattjala mattjala marked this pull request as ready for review September 6, 2023 21:00
src/CMakeLists.txt Outdated Show resolved Hide resolved
autogen.sh Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
@mattjala mattjala marked this pull request as draft September 7, 2023 21:41
@mattjala mattjala marked this pull request as ready for review September 11, 2023 14:38
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
build_vol_cmake.sh Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
test/vol-tests Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid any of the steps in this workflow file using valgrind to run tests since for the most part that will just make them take significantly longer. We can setup another workflow in the future that uses sanitizers to check for this stuff without affecting the runtime much.

@jhendersonHDF jhendersonHDF merged commit 475a135 into HDFGroup:master Sep 13, 2023
10 checks passed
@mattjala mattjala deleted the build_under_library branch March 21, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants