Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons headers are not properly installed #227

Open
tmadlener opened this issue Nov 15, 2022 · 1 comment
Open

addons headers are not properly installed #227

tmadlener opened this issue Nov 15, 2022 · 1 comment

Comments

@tmadlener
Copy link
Contributor

I ran into this because EDM4hep seems to try and pick up the shared libraries/dictionaries that are built by FCCAnalyses in CI:
https://github.com/key4hep/EDM4hep/actions/runs/3468331195/jobs/5794042094#step:4:589

The problem seems to be that the FastJet/JetClustering.h is not installed. I didn't yet check very thoroughly, but it seems that none of the header files in the addons/FastJet folder are installed to prefix/include.

@tmadlener
Copy link
Contributor Author

Also the CMake config needs adaptation most likely:

$<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/addons>

Alternatively if these are private headers, they should be declared as such (and removed from the public headers)

tmadlener added a commit to tmadlener/FCCAnalyses that referenced this issue Nov 29, 2022
bistapf added a commit to bistapf/FCCAnalyses that referenced this issue Nov 29, 2022
Install the FastJet addons headers to work around HEP-FCC#227
tmadlener added a commit to tmadlener/FCCAnalyses that referenced this issue Nov 30, 2022
mvoorde pushed a commit to mvoorde/FCCAnalyses_LLP that referenced this issue Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant