Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuous integration builds and make JSON support more robust at build #185

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Nov 15, 2022

BEGINRELEASENOTES

  • Only build JSON support if a suitable version of nlohmann/json is found. This should fix a few issues in CI.
  • Fix formatting of edm4hep2json.
  • Update versions of github actions used in CI to latest available.

ENDRELEASENOTES

@tmadlener
Copy link
Contributor Author

key4hep nightlies are failing because of HEP-FCC/FCCAnalyses#227

@tmadlener tmadlener changed the title Make building of json support dependent on nlohmann_json version Fix continuous integration builds and make JSON support more robust at build Nov 15, 2022
@tmadlener
Copy link
Contributor Author

Merging without waiting on the FCCAnalyses fix, in order to fix at least a few of the other CI workflows.

@tmadlener tmadlener merged commit 3911458 into key4hep:master Nov 15, 2022
@tmadlener tmadlener deleted the fix-ci branch November 15, 2022 12:20
@vvolkl
Copy link
Collaborator

vvolkl commented Nov 30, 2022

Thanks for the fix - something is still wrong though when fccanalyses can break the edm4hep tests, that's not how dependencies should work... Maybe a name collision in the rdf test?

@tmadlener
Copy link
Contributor Author

tmadlener commented Dec 1, 2022

Yeah, I agree that this really should not happen, but I suspect the culprit in this case is ROOT that loads dictionaries a bit too eagerly. I suppose it would be possible to set the test environment even stricter to exclude, e.g. other dictionaries to be discoverable during tests. However, I seem to remember, that I have struggled with this already quite a bit in the past, due to how different e.g. an LCG (view) environment is compared to one from a key4hep stack build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants